PMD Results

The following document contains the results of PMD 7.17.0.

Violations By Priority

Priority 3

de/dlr/shepard/data/timeseries/migrations/V1_7_0__int_to_bigint.java

Rule Violation Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 27

de/dlr/shepard/data/timeseries/utilities/CsvInputStream.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 2224

Priority 4

de/dlr/shepard/auth/apikey/entities/ApiKey.java

Rule Violation Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(belongsTo, other.belongsTo) ...`. 7884

de/dlr/shepard/auth/permission/model/Permissions.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 109119

de/dlr/shepard/auth/users/endpoints/UserGroupAttributes.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'UserGroupAttributes': 'name' is already in scope because it is declared in an enclosing type 11

de/dlr/shepard/auth/users/entities/User.java

Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(apiKeys, other.api...`. 8289

de/dlr/shepard/auth/users/io/UserGroupIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(usernames, other.usernames)`. 33

de/dlr/shepard/common/neo4j/entities/AbstractEntity.java

Rule Violation Line
UselessParentheses Useless parentheses around `deleted == entity.deleted && Objects.equals(id,...`. 7279

de/dlr/shepard/common/neo4j/entities/BasicEntity.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && deleted == othe...`. 6069

de/dlr/shepard/common/neo4j/io/AbstractDataObjectIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(description, other.description) ...`. 35

de/dlr/shepard/common/neo4j/io/BasicEntityIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 8491

de/dlr/shepard/common/neo4j/migrations/V2__Extract_json.java

Rule Violation Line
UselessParentheses Useless parentheses around `100f / size`. 301
UselessParentheses Useless parentheses around `100f / size`. 302

de/dlr/shepard/common/search/daos/SearchDAO.java

Rule Violation Line
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 108113
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 117122
UselessParentheses Useless parentheses around `(pagination != null ? " " + CypherQueryHelper.g...`. 126132

de/dlr/shepard/common/search/endpoints/BasicCollectionAttributes.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'name' is already in scope because it is declared in an enclosing type 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 15

de/dlr/shepard/common/search/endpoints/BasicContainerAttributes.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'type' is already in scope because it is declared in an enclosing type 15
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 16

de/dlr/shepard/common/search/query/Neo4jQueryBuilder.java

Rule Violation Line
UselessParentheses Useless parentheses around `"((" + neighborhoodIdsIsContainedInPart(node, v...`. 409415

de/dlr/shepard/common/subscription/entities/Subscription.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(callbackURL, other.callbackURL) ...`. 7381

de/dlr/shepard/common/util/CypherQueryHelper.java

Rule Violation Line
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 70
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 7478
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 8287
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CypherQueryHelper': 'getPaginationPart' is already in scope 84

de/dlr/shepard/context/collection/endpoints/DataObjectAttributes.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataObjectAttributes': 'name' is already in scope because it is declared in an enclosing type 11

de/dlr/shepard/context/collection/entities/Collection.java

Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(dataObjects, other...`. 7379

de/dlr/shepard/context/collection/entities/DataObject.java

Rule Violation Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(collection, other.collection...`. 99108

de/dlr/shepard/context/collection/io/CollectionIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(dataObjectIds, other.dataObj...`. 4852

de/dlr/shepard/context/collection/io/DataObjectIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `collectionId == other.collectionId && HasId.are...`. 5361

de/dlr/shepard/context/labjournal/entities/LabJournalEntry.java

Rule Violation Line
UselessParentheses Useless parentheses around `super.equals(other) && Objects.equals(content, ...`. 4143

de/dlr/shepard/context/references/basicreference/endpoints/BasicReferenceAttributes.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'name' is already in scope because it is declared in an enclosing type 13
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'type' is already in scope because it is declared in an enclosing type 14

de/dlr/shepard/context/references/basicreference/io/BasicReferenceIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `dataObjectId == other.dataObjectId && Objects.e...`. 34

de/dlr/shepard/context/references/dataobject/entities/CollectionReference.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 4952

de/dlr/shepard/context/references/dataobject/entities/DataObjectReference.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 4952

de/dlr/shepard/context/references/file/io/FileReferenceIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `fileContainerId == other.fileContainerId && Has...`. 39

de/dlr/shepard/context/references/structureddata/entities/StructuredDataReference.java

Rule Violation Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(structuredDataContainer...) ...`. 5760

de/dlr/shepard/context/references/structureddata/io/StructuredDataReferenceIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `structuredDataContainerId == other.structuredDa...`. 4144

de/dlr/shepard/context/references/timeseriesreference/model/TimeseriesReference.java

Rule Violation Line
UselessParentheses Useless parentheses around `end == other.end && start == other.start && Obj...`. 6166

de/dlr/shepard/context/references/timeseriesreference/services/TimeseriesReferenceMetricsService.java

Rule Violation Line
UselessParentheses Useless parentheses around `metric != AggregateFunction.COUNT && metric != ...`. 119

de/dlr/shepard/context/semantic/endpoints/SemanticRepositoryAttributes.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SemanticRepositoryAttributes': 'name' is already in scope because it is declared in an enclosing type 11

de/dlr/shepard/context/semantic/entities/SemanticAnnotation.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 6876

de/dlr/shepard/context/version/entities/Version.java

Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(createdAt, other.createdAt) && O...`. 102110

de/dlr/shepard/data/ContainerAttributes.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 11

de/dlr/shepard/data/timeseries/daos/TimeseriesDAO.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 132
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 133
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 134
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 136
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CypherDslHelper': 'notDeleted' is already in scope 140
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'match' is already in scope 163

de/dlr/shepard/data/timeseries/io/TimeseriesIO.java

Rule Violation Line
UselessParentheses Useless parentheses around `id == that.id && containerId == that.containerI...`. 7282

de/dlr/shepard/data/timeseries/repositories/TimeseriesDataPointRepository.java

Rule Violation Line
UselessParentheses Useless parentheses around `function.isPresent() && function.get() != Aggre...`. 309312
UselessParentheses Useless parentheses around `fillOption.isPresent()`. 326

Files

de/dlr/shepard/auth/apikey/entities/ApiKey.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(belongsTo, other.belongsTo) ...`. 4 7884

de/dlr/shepard/auth/permission/model/Permissions.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 4 109119

de/dlr/shepard/auth/users/endpoints/UserGroupAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'UserGroupAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/auth/users/entities/User.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(apiKeys, other.api...`. 4 8289

de/dlr/shepard/auth/users/io/UserGroupIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(usernames, other.usernames)`. 4 33

de/dlr/shepard/common/neo4j/entities/AbstractEntity.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `deleted == entity.deleted && Objects.equals(id,...`. 4 7279

de/dlr/shepard/common/neo4j/entities/BasicEntity.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && deleted == othe...`. 4 6069

de/dlr/shepard/common/neo4j/io/AbstractDataObjectIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(description, other.description) ...`. 4 35

de/dlr/shepard/common/neo4j/io/BasicEntityIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 4 8491

de/dlr/shepard/common/neo4j/migrations/V2__Extract_json.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `100f / size`. 4 301
UselessParentheses Useless parentheses around `100f / size`. 4 302

de/dlr/shepard/common/search/daos/SearchDAO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 4 108113
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 4 117122
UselessParentheses Useless parentheses around `(pagination != null ? " " + CypherQueryHelper.g...`. 4 126132

de/dlr/shepard/common/search/endpoints/BasicCollectionAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'name' is already in scope because it is declared in an enclosing type 4 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 4 15

de/dlr/shepard/common/search/endpoints/BasicContainerAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 4 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'type' is already in scope because it is declared in an enclosing type 4 15
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 4 16

de/dlr/shepard/common/search/query/Neo4jQueryBuilder.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `"((" + neighborhoodIdsIsContainedInPart(node, v...`. 4 409415

de/dlr/shepard/common/subscription/entities/Subscription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(callbackURL, other.callbackURL) ...`. 4 7381

de/dlr/shepard/common/util/CypherQueryHelper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 4 70
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 4 7478
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 4 8287
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CypherQueryHelper': 'getPaginationPart' is already in scope 4 84

de/dlr/shepard/context/collection/endpoints/DataObjectAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataObjectAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/context/collection/entities/Collection.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(dataObjects, other...`. 4 7379

de/dlr/shepard/context/collection/entities/DataObject.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(collection, other.collection...`. 4 99108

de/dlr/shepard/context/collection/io/CollectionIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(dataObjectIds, other.dataObj...`. 4 4852

de/dlr/shepard/context/collection/io/DataObjectIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `collectionId == other.collectionId && HasId.are...`. 4 5361

de/dlr/shepard/context/labjournal/entities/LabJournalEntry.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `super.equals(other) && Objects.equals(content, ...`. 4 4143

de/dlr/shepard/context/references/basicreference/endpoints/BasicReferenceAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'name' is already in scope because it is declared in an enclosing type 4 13
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'type' is already in scope because it is declared in an enclosing type 4 14

de/dlr/shepard/context/references/basicreference/io/BasicReferenceIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `dataObjectId == other.dataObjectId && Objects.e...`. 4 34

de/dlr/shepard/context/references/dataobject/entities/CollectionReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 4 4952

de/dlr/shepard/context/references/dataobject/entities/DataObjectReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 4 4952

de/dlr/shepard/context/references/file/io/FileReferenceIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `fileContainerId == other.fileContainerId && Has...`. 4 39

de/dlr/shepard/context/references/structureddata/entities/StructuredDataReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(structuredDataContainer...) ...`. 4 5760

de/dlr/shepard/context/references/structureddata/io/StructuredDataReferenceIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `structuredDataContainerId == other.structuredDa...`. 4 4144

de/dlr/shepard/context/references/timeseriesreference/model/TimeseriesReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `end == other.end && start == other.start && Obj...`. 4 6166

de/dlr/shepard/context/references/timeseriesreference/services/TimeseriesReferenceMetricsService.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `metric != AggregateFunction.COUNT && metric != ...`. 4 119

de/dlr/shepard/context/semantic/endpoints/SemanticRepositoryAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SemanticRepositoryAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/context/semantic/entities/SemanticAnnotation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 4 6876

de/dlr/shepard/context/version/entities/Version.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(createdAt, other.createdAt) && O...`. 4 102110

de/dlr/shepard/data/ContainerAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/data/timeseries/daos/TimeseriesDAO.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 4 132
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 4 133
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 4 134
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'node' is already in scope 4 136
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CypherDslHelper': 'notDeleted' is already in scope 4 140
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Cypher': 'match' is already in scope 4 163

de/dlr/shepard/data/timeseries/io/TimeseriesIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `id == that.id && containerId == that.containerI...`. 4 7282

de/dlr/shepard/data/timeseries/migrations/V1_7_0__int_to_bigint.java

Rule Violation Priority Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 27

de/dlr/shepard/data/timeseries/repositories/TimeseriesDataPointRepository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `function.isPresent() && function.get() != Aggre...`. 4 309312
UselessParentheses Useless parentheses around `fillOption.isPresent()`. 4 326

de/dlr/shepard/data/timeseries/utilities/CsvInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 2224