Built by Maven

PMD Results

The following document contains the results of PMD 7.17.0.

Violations By Priority

Priority 3

de/dlr/shepard/context/export/ExportService.java
Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'collectionId'. 130
UnusedFormalParameter Avoid unused method parameters such as 'dataObjectId'. 131
UnusedFormalParameter Avoid unused method parameters such as 'username'. 144
UnusedFormalParameter Avoid unused method parameters such as 'username'. 223
de/dlr/shepard/context/labJournal/entities/LabJournalEntry.java
Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 28
de/dlr/shepard/data/timeseries/daos/TimeseriesDAO.java
Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 1–128
de/dlr/shepard/data/timeseries/migrations/V1_7_0__int_to_bigint.java
Rule Violation Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 27
de/dlr/shepard/data/timeseries/utilities/CsvInputStream.java
Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 22–24

Priority 4

de/dlr/shepard/ShepardMain.java
Rule Violation Line
UnnecessaryImport Unused import 'jakarta.annotation.Nullable' 13
de/dlr/shepard/auth/apikey/entities/ApiKey.java
Rule Violation Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(belongsTo, other.belongsTo) ...`. 78–84
de/dlr/shepard/auth/permission/model/Permissions.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 109–119
de/dlr/shepard/auth/users/endpoints/UserGroupAttributes.java
Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'UserGroupAttributes': 'name' is already in scope because it is declared in an enclosing type 11
de/dlr/shepard/auth/users/entities/User.java
Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(apiKeys, other.api...`. 82–89
de/dlr/shepard/auth/users/io/UserGroupIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(usernames, other.usernames)`. 33
de/dlr/shepard/common/neo4j/MigrationsRunner.java
Rule Violation Line
UnnecessaryImport Unused import 'ac.simons.neo4j.migrations.core.MigrationsException' 6
UnnecessaryImport Unused import 'org.neo4j.driver.exceptions.ServiceUnavailableException' 14
de/dlr/shepard/common/neo4j/entities/AbstractEntity.java
Rule Violation Line
UselessParentheses Useless parentheses around `id.equals(entity.id) && deleted == entity.delet...`. 72–79
de/dlr/shepard/common/neo4j/entities/BasicEntity.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && deleted == othe...`. 60–69
de/dlr/shepard/common/neo4j/io/AbstractDataObjectIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(description, other.description) ...`. 35
de/dlr/shepard/common/neo4j/io/BasicEntityIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 84–91
de/dlr/shepard/common/neo4j/migrations/V2__Extract_json.java
Rule Violation Line
UselessParentheses Useless parentheses around `100f / size`. 294
UselessParentheses Useless parentheses around `100f / size`. 295
de/dlr/shepard/common/search/daos/SearchDAO.java
Rule Violation Line
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 101–106
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 110–115
UselessParentheses Useless parentheses around `(pagination != null ? " " + CypherQueryHelper.g...`. 119–125
de/dlr/shepard/common/search/endpoints/BasicCollectionAttributes.java
Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'name' is already in scope because it is declared in an enclosing type 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 15
de/dlr/shepard/common/search/endpoints/BasicContainerAttributes.java
Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'type' is already in scope because it is declared in an enclosing type 15
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 16
de/dlr/shepard/common/search/query/Neo4jQueryBuilder.java
Rule Violation Line
UselessParentheses Useless parentheses around `"((" + neighborhoodIdsIsContainedInPart(node, v...`. 312–318
de/dlr/shepard/common/subscription/entities/Subscription.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(callbackURL, other.callbackURL) ...`. 73–81
de/dlr/shepard/common/util/CypherQueryHelper.java
Rule Violation Line
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 68
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 72–76
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 80–85
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CypherQueryHelper': 'getPaginationPart' is already in scope 82
de/dlr/shepard/context/collection/endpoints/DataObjectAttributes.java
Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataObjectAttributes': 'name' is already in scope because it is declared in an enclosing type 11
de/dlr/shepard/context/collection/entities/Collection.java
Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(dataObjects, other...`. 73–79
de/dlr/shepard/context/collection/entities/DataObject.java
Rule Violation Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(collection, other.collection...`. 99–108
de/dlr/shepard/context/collection/io/CollectionIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(dataObjectIds, other.dataObj...`. 48–52
de/dlr/shepard/context/collection/io/DataObjectIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `collectionId == other.collectionId && HasId.are...`. 53–61
de/dlr/shepard/context/references/basicreference/endpoints/BasicReferenceAttributes.java
Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'name' is already in scope because it is declared in an enclosing type 13
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'type' is already in scope because it is declared in an enclosing type 14
de/dlr/shepard/context/references/basicreference/io/BasicReferenceIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `dataObjectId == other.dataObjectId && Objects.e...`. 34
de/dlr/shepard/context/references/dataobject/entities/CollectionReference.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 49–52
de/dlr/shepard/context/references/dataobject/entities/DataObjectReference.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 49–52
de/dlr/shepard/context/references/file/io/FileReferenceIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `fileContainerId == other.fileContainerId && Has...`. 39
de/dlr/shepard/context/references/structureddata/entities/StructuredDataReference.java
Rule Violation Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(structuredDataContainer...) ...`. 57–60
de/dlr/shepard/context/references/structureddata/io/StructuredDataReferenceIO.java
Rule Violation Line
UselessParentheses Useless parentheses around `structuredDataContainerId == other.structuredDa...`. 41–44
de/dlr/shepard/context/references/timeseriesreference/model/TimeseriesReference.java
Rule Violation Line
UselessParentheses Useless parentheses around `end == other.end && start == other.start && Obj...`. 61–66
de/dlr/shepard/context/references/timeseriesreference/services/TimeseriesReferenceMetricsService.java
Rule Violation Line
UnnecessaryImport Unused import 'de.dlr.shepard.data.timeseries.model.Timeseries' 6
UselessParentheses Useless parentheses around `metric != AggregateFunction.COUNT && metric != ...`. 120
de/dlr/shepard/context/semantic/endpoints/SemanticRepositoryAttributes.java
Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SemanticRepositoryAttributes': 'name' is already in scope because it is declared in an enclosing type 11
de/dlr/shepard/context/semantic/entities/SemanticAnnotation.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 68–76
de/dlr/shepard/context/version/entities/Version.java
Rule Violation Line
UselessParentheses Useless parentheses around `Objects.equals(createdAt, other.createdAt) && O...`. 102–110
de/dlr/shepard/data/ContainerAttributes.java
Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 11
de/dlr/shepard/data/timeseries/endpoints/TimeseriesRest.java
Rule Violation Line
UnnecessaryImport Unused import 'java.util.NoSuchElementException' 51
de/dlr/shepard/data/timeseries/migrations/V1_7_0__int_to_bigint.java
Rule Violation Line
UnnecessaryImport Unused import 'org.flywaydb.core.api.MigrationVersion' 7
de/dlr/shepard/data/timeseries/repositories/TimeseriesDataPointRepository.java
Rule Violation Line
UselessParentheses Useless parentheses around `function.isPresent() && function.get() != Aggre...`. 310–313
UselessParentheses Useless parentheses around `fillOption.isPresent()`. 327

Files

de/dlr/shepard/ShepardMain.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'jakarta.annotation.Nullable' 4 13

de/dlr/shepard/auth/apikey/entities/ApiKey.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(belongsTo, other.belongsTo) ...`. 4 78–84

de/dlr/shepard/auth/permission/model/Permissions.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 4 109–119

de/dlr/shepard/auth/users/endpoints/UserGroupAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'UserGroupAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/auth/users/entities/User.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(apiKeys, other.api...`. 4 82–89

de/dlr/shepard/auth/users/io/UserGroupIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(usernames, other.usernames)`. 4 33

de/dlr/shepard/common/neo4j/MigrationsRunner.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'ac.simons.neo4j.migrations.core.MigrationsException' 4 6
UnnecessaryImport Unused import 'org.neo4j.driver.exceptions.ServiceUnavailableException' 4 14

de/dlr/shepard/common/neo4j/entities/AbstractEntity.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `id.equals(entity.id) && deleted == entity.delet...`. 4 72–79

de/dlr/shepard/common/neo4j/entities/BasicEntity.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && deleted == othe...`. 4 60–69

de/dlr/shepard/common/neo4j/io/AbstractDataObjectIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(description, other.description) ...`. 4 35

de/dlr/shepard/common/neo4j/io/BasicEntityIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 4 84–91

de/dlr/shepard/common/neo4j/migrations/V2__Extract_json.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `100f / size`. 4 294
UselessParentheses Useless parentheses around `100f / size`. 4 295

de/dlr/shepard/common/search/daos/SearchDAO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 4 101–106
UselessParentheses Useless parentheses around `" WITH " + containerVariable + " " + CypherQuer...`. 4 110–115
UselessParentheses Useless parentheses around `(pagination != null ? " " + CypherQueryHelper.g...`. 4 119–125

de/dlr/shepard/common/search/endpoints/BasicCollectionAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'name' is already in scope because it is declared in an enclosing type 4 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicCollectionAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 4 15

de/dlr/shepard/common/search/endpoints/BasicContainerAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 4 14
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'type' is already in scope because it is declared in an enclosing type 4 15
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicContainerAttributes': 'createdBy' is already in scope because it is declared in an enclosing type 4 16

de/dlr/shepard/common/search/query/Neo4jQueryBuilder.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `"((" + neighborhoodIdsIsContainedInPart(node, v...`. 4 312–318

de/dlr/shepard/common/subscription/entities/Subscription.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(callbackURL, other.callbackURL) ...`. 4 73–81

de/dlr/shepard/common/util/CypherQueryHelper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 4 68
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 4 72–76
UselessParentheses Useless parentheses around `getNeighborhoodPart(entity, neighborhood...) + ...`. 4 80–85
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CypherQueryHelper': 'getPaginationPart' is already in scope 4 82

de/dlr/shepard/context/collection/endpoints/DataObjectAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataObjectAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/context/collection/entities/Collection.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSetsByUniqueId(dataObjects, other...`. 4 73–79

de/dlr/shepard/context/collection/entities/DataObject.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(collection, other.collection...`. 4 99–108

de/dlr/shepard/context/collection/io/CollectionIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.areEqualSets(dataObjectIds, other.dataObj...`. 4 48–52

de/dlr/shepard/context/collection/io/DataObjectIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `collectionId == other.collectionId && HasId.are...`. 4 53–61

de/dlr/shepard/context/export/ExportService.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'collectionId'. 3 130
UnusedFormalParameter Avoid unused method parameters such as 'dataObjectId'. 3 131
UnusedFormalParameter Avoid unused method parameters such as 'username'. 3 144
UnusedFormalParameter Avoid unused method parameters such as 'username'. 3 223

de/dlr/shepard/context/labJournal/entities/LabJournalEntry.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 28

de/dlr/shepard/context/references/basicreference/endpoints/BasicReferenceAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'name' is already in scope because it is declared in an enclosing type 4 13
UnnecessaryFullyQualifiedName Unnecessary qualifier 'BasicReferenceAttributes': 'type' is already in scope because it is declared in an enclosing type 4 14

de/dlr/shepard/context/references/basicreference/io/BasicReferenceIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `dataObjectId == other.dataObjectId && Objects.e...`. 4 34

de/dlr/shepard/context/references/dataobject/entities/CollectionReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 4 49–52

de/dlr/shepard/context/references/dataobject/entities/DataObjectReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(relationship, other.relationship...`. 4 49–52

de/dlr/shepard/context/references/file/io/FileReferenceIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `fileContainerId == other.fileContainerId && Has...`. 4 39

de/dlr/shepard/context/references/structureddata/entities/StructuredDataReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `HasId.equalsHelper(structuredDataContainer...) ...`. 4 57–60

de/dlr/shepard/context/references/structureddata/io/StructuredDataReferenceIO.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `structuredDataContainerId == other.structuredDa...`. 4 41–44

de/dlr/shepard/context/references/timeseriesreference/model/TimeseriesReference.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `end == other.end && start == other.start && Obj...`. 4 61–66

de/dlr/shepard/context/references/timeseriesreference/services/TimeseriesReferenceMetricsService.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'de.dlr.shepard.data.timeseries.model.Timeseries' 4 6
UselessParentheses Useless parentheses around `metric != AggregateFunction.COUNT && metric != ...`. 4 120

de/dlr/shepard/context/semantic/endpoints/SemanticRepositoryAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SemanticRepositoryAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/context/semantic/entities/SemanticAnnotation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(id, other.id) && Objects.equals(...`. 4 68–76

de/dlr/shepard/context/version/entities/Version.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `Objects.equals(createdAt, other.createdAt) && O...`. 4 102–110

de/dlr/shepard/data/ContainerAttributes.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ContainerAttributes': 'name' is already in scope because it is declared in an enclosing type 4 11

de/dlr/shepard/data/timeseries/daos/TimeseriesDAO.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 1–128

de/dlr/shepard/data/timeseries/endpoints/TimeseriesRest.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'java.util.NoSuchElementException' 4 51

de/dlr/shepard/data/timeseries/migrations/V1_7_0__int_to_bigint.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'org.flywaydb.core.api.MigrationVersion' 4 7
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 27

de/dlr/shepard/data/timeseries/repositories/TimeseriesDataPointRepository.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `function.isPresent() && function.get() != Aggre...`. 4 310–313
UselessParentheses Useless parentheses around `fillOption.isPresent()`. 4 327

de/dlr/shepard/data/timeseries/utilities/CsvInputStream.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 22–24